S8RuleHandlerPoolTests.cs 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320
  1. using System.Reflection;
  2. using Admin.NET.Plugin.AiDOP.Const.S8;
  3. using Admin.NET.Plugin.AiDOP.Entity.S8;
  4. using Admin.NET.Plugin.AiDOP.Infrastructure.S8;
  5. using Admin.NET.Plugin.AiDOP.Service.S8;
  6. using Admin.NET.Plugin.AiDOP.Service.S8.Rules;
  7. using Xunit;
  8. namespace Admin.NET.Plugin.AiDOP.Tests.S8;
  9. /// <summary>
  10. /// S8-HANDLER-POOL-1:规则处理账号池与认领资格。
  11. ///
  12. /// <para><b>三个正交维度</b>:动作权限(角色能做什么)· 规则责任(账号负责哪条规则)·
  13. /// 状态机(单据现在能不能做)。最终允许 = 三者交集。把它们混在一处判断是本仓踩过的坑:
  14. /// 某一维被"顺手"放宽后,另外两维看起来仍然正常,缺陷只在特定组合下出现。</para>
  15. /// </summary>
  16. public class S8RuleHandlerPoolTests
  17. {
  18. private const BindingFlags Instance =
  19. BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic;
  20. private static readonly string PluginRoot =
  21. Path.GetFullPath(Path.Combine(AppContext.BaseDirectory, "../../../../Admin.NET.Plugin.AiDOP"));
  22. private static string CodeOnly(string relativePath)
  23. {
  24. var full = Path.Combine(PluginRoot, relativePath.Replace('/', Path.DirectorySeparatorChar));
  25. Assert.True(File.Exists(full), $"源码文件不存在,路径需同步更新:{full}");
  26. return string.Join('\n', File.ReadAllLines(full)
  27. .Where(l =>
  28. {
  29. var t = l.TrimStart();
  30. return !t.StartsWith("///", StringComparison.Ordinal)
  31. && !t.StartsWith("//", StringComparison.Ordinal);
  32. }));
  33. }
  34. // ══════════════════════════════════════════════════════════════════════════
  35. // 存储形态
  36. // ══════════════════════════════════════════════════════════════════════════
  37. /// <summary>
  38. /// 身份是 (租户, 规则编码, 账号)。
  39. ///
  40. /// <para><b>必须是 rule_code 而不是 rule_id</b>:provisioning 的身份口径就是
  41. /// (TenantId, RuleCode),而 watch_rule 的行会被重建 —— 1.0.496 的 clean reset
  42. /// 之后 id 全部变化。绑 id 会让人员池在那一刻集体失联,而且不报错:
  43. /// 规则照常跑,只是谁都不再"负责"它。</para>
  44. /// </summary>
  45. [Fact]
  46. public void Storage_IdentityIsTenantRuleCodeUser()
  47. {
  48. var t = typeof(AdoS8RuleHandlerUser);
  49. Assert.NotNull(t.GetProperty("TenantId"));
  50. Assert.NotNull(t.GetProperty("RuleCode"));
  51. Assert.NotNull(t.GetProperty("UserId"));
  52. Assert.Null(t.GetProperty("RuleId")); // 绑 id 会在规则行重建时集体失联
  53. Assert.Null(t.GetProperty("FactoryId")); // 工厂不是隔离维度
  54. Assert.Null(t.GetProperty("EmployeeId")); // S8 的人只有系统账号
  55. }
  56. /// <summary>人员池不得回流进 params_json —— 那个字段有被整块抹成 NULL 的事故先例。</summary>
  57. [Fact]
  58. public void HandlerPool_IsNotStoredInParamsJson()
  59. {
  60. var code = CodeOnly("Service/S8/Rules/S8RuleRuntimeParameters.cs");
  61. Assert.DoesNotContain("HandlerUser", code);
  62. Assert.DoesNotContain("handlerUserIds", code);
  63. // params_json 的 B 类键仍然只有那三项
  64. Assert.Contains("KeyGraceMinutes", code);
  65. Assert.Contains("KeyDefaultOccurrenceDeptId", code);
  66. Assert.Contains("KeyDefaultResponsibleDeptId", code);
  67. }
  68. // ══════════════════════════════════════════════════════════════════════════
  69. // 成员合法性
  70. // ══════════════════════════════════════════════════════════════════════════
  71. /// <summary>
  72. /// 成员合法性复用 <see cref="IS8UserScopeValidator"/>,不另写一套判据。
  73. /// 池成员与认领人必须用同一把尺子,否则会出现「配得进池、认领时又被拒」——
  74. /// 这种状态管理员完全无法自查。
  75. /// </summary>
  76. [Fact]
  77. public void Membership_ReusesUserScopeValidator()
  78. {
  79. var code = CodeOnly("Service/S8/S8RuleHandlerPoolService.cs");
  80. Assert.Contains("_userScope.ValidateUsersAsync", code);
  81. Assert.Contains("_userScope.FindActiveUserAsync", code);
  82. // 不得绕过 validator 自己拼 SysUser 查询
  83. Assert.DoesNotContain("Queryable<SysUser>", code);
  84. Assert.DoesNotContain("StatusEnum.Enable", code);
  85. // 跨租户与不存在共用同一文案,不泄漏存在性
  86. Assert.Contains("所选账号不存在或已停用", code);
  87. }
  88. /// <summary>
  89. /// 失效成员必须<b>返回并标记</b>,不能静默过滤。
  90. /// 账号被停用之后池子无声地少一个人,管理员既看不见也不知道要补。
  91. /// </summary>
  92. [Fact]
  93. public void InvalidMembers_AreSurfacedNotSilentlyDropped()
  94. {
  95. var code = CodeOnly("Service/S8/S8RuleHandlerPoolService.cs");
  96. Assert.Contains("Valid = false", code);
  97. Assert.Contains("账号已停用或不在本租户", code);
  98. }
  99. /// <summary>责任池链路上不得出现工厂或员工。</summary>
  100. [Theory]
  101. [InlineData("Service/S8/S8RuleHandlerPoolService.cs")]
  102. [InlineData("Infrastructure/S8/S8ClaimEligibility.cs")]
  103. public void HandlerPoolChain_HasNoFactoryOrEmployee(string relativePath)
  104. {
  105. var code = CodeOnly(relativePath);
  106. Assert.DoesNotContain("FactoryId", code);
  107. Assert.DoesNotContain("FactoryRefId", code);
  108. Assert.DoesNotContain("EmployeeMaster", code);
  109. }
  110. // ══════════════════════════════════════════════════════════════════════════
  111. // 认领资格:三维正交
  112. // ══════════════════════════════════════════════════════════════════════════
  113. /// <summary>
  114. /// 认领资格 = 动作权限 ∩ 规则责任,且两个拒绝原因<b>可分辨</b>。
  115. ///
  116. /// <para>「没权限」与「不负责这条规则」是两种完全不同的处境,给用户同一句话
  117. /// 会让他去找错人 —— 前者要找管理员配角色,后者要找管理员加责任池。</para>
  118. /// </summary>
  119. [Fact]
  120. public void ClaimEligibility_CombinesPermissionAndResponsibility()
  121. {
  122. var code = CodeOnly("Infrastructure/S8/S8ClaimEligibility.cs");
  123. Assert.Contains("_authorizer.AuthorizeAsync(tenantId, userId, S8ExceptionActionCode.Claim)", code);
  124. Assert.Contains("_handlerPool.IsMemberAsync", code);
  125. Assert.Contains(S8ClaimDenyReason.NoActionPermission, code);
  126. Assert.Contains(S8ClaimDenyReason.NotInHandlerPool, code);
  127. Assert.NotEqual(S8ClaimDenyReason.NoActionPermission, S8ClaimDenyReason.NotInHandlerPool);
  128. }
  129. /// <summary>
  130. /// 人工提报无来源规则,<b>不受责任池约束</b>。
  131. /// 若一刀切要求入池,人工提报的异常将永远无人可认领。
  132. /// </summary>
  133. [Fact]
  134. public void ManualReport_IsNotConstrainedByHandlerPool()
  135. {
  136. var code = CodeOnly("Infrastructure/S8/S8ClaimEligibility.cs");
  137. Assert.Contains("string.IsNullOrWhiteSpace(ruleCode)", code);
  138. Assert.Contains("return S8ClaimEligibilityResult.Pass();", code);
  139. }
  140. /// <summary>
  141. /// 状态机与并发那一维<b>不在资格判定里重复实现</b> ——
  142. /// 仍由 <c>S8TaskFlowService</c> 的原子 UPDATE 负责,First Claim Wins 不受本批影响。
  143. /// </summary>
  144. [Fact]
  145. public void ClaimEligibility_DoesNotDuplicateStateOrConcurrency()
  146. {
  147. var elig = CodeOnly("Infrastructure/S8/S8ClaimEligibility.cs");
  148. Assert.DoesNotContain("S8StatusRules", elig);
  149. Assert.DoesNotContain("AssigneeUserId", elig);
  150. var flow = CodeOnly("Service/S8/S8TaskFlowService.cs");
  151. Assert.Contains("_claimEligibility.CheckAsync(tenantId, currentUserId, e)", flow);
  152. // 原子谓词与竞争败者文案仍在
  153. Assert.Contains("x.AssigneeUserId == null", flow);
  154. Assert.Contains("该异常已被其他人员认领", flow);
  155. }
  156. /// <summary>
  157. /// 转派目标同样受责任池约束 —— 不留「转给池外账号」的后门。
  158. ///
  159. /// <para>留后门等于绕过责任池本身:池子写着 A、B 负责,实际单据却落到 C 手里,
  160. /// 而池配置看起来仍然正确。</para>
  161. /// </summary>
  162. [Fact]
  163. public void Transfer_TargetMustBeInHandlerPool()
  164. {
  165. var flow = CodeOnly("Service/S8/S8TaskFlowService.cs");
  166. Assert.Contains("_handlerPool.IsMemberAsync(tenantId, e.SourceRuleCode!, target.UserId)", flow);
  167. Assert.Contains("不是该规则的处理人员,无法转派", flow);
  168. // 人工提报同样豁免(与认领同口径)
  169. Assert.Contains("!string.IsNullOrWhiteSpace(e.SourceRuleCode)", flow);
  170. }
  171. /// <summary>认领资格必须只有一份实现。</summary>
  172. [Fact]
  173. public void ClaimEligibility_HasSingleImplementation()
  174. {
  175. var impls = typeof(IS8ClaimEligibility).Assembly.GetTypes()
  176. .Where(t => t is { IsAbstract: false, IsInterface: false }
  177. && typeof(IS8ClaimEligibility).IsAssignableFrom(t))
  178. .ToList();
  179. Assert.Single(impls);
  180. Assert.Equal(typeof(S8ClaimEligibility), impls[0]);
  181. }
  182. // ══════════════════════════════════════════════════════════════════════════
  183. // 启用门禁
  184. // ══════════════════════════════════════════════════════════════════════════
  185. /// <summary>
  186. /// 启用要求至少一名<b>当前有效</b>的处理账号。
  187. ///
  188. /// <para>判据不能是"表里有没有行":账号被停用之后那行还在,但人已经不能认领了。
  189. /// 只数行数会让一条实际上没人能处理的规则通过启用检查 —— 那正是本门禁存在的意义。</para>
  190. /// </summary>
  191. [Fact]
  192. public void Enable_RequiresAtLeastOneValidHandler()
  193. {
  194. var code = CodeOnly("Service/S8/Rules/S8RuleReadinessGate.cs");
  195. Assert.Contains(S8RuleReadinessReasonCode.HandlerPoolEmpty, code);
  196. // S8-RESPONSIBILITY-POOL-1:三类责任池走统一 reader,处理池由 responsibilityType 指定。
  197. Assert.Contains("_pools.GetMembersAsync(tenantId, ruleCode, responsibilityType)", code);
  198. Assert.Contains("S8ResponsibilityType.Handler", code);
  199. // 有效性判据:不是 Count > 0,而是"存在一个 Valid 的"
  200. Assert.Contains("members.Any(m => m.Valid)", code);
  201. Assert.DoesNotContain("members.Count > 0)", code);
  202. // 两种失败要给不同提示:没配过 vs 配过但都失效
  203. Assert.Contains("请先配置至少一名处理账号", code);
  204. Assert.Contains("均已停用或不在当前租户", code);
  205. }
  206. /// <summary>
  207. /// Preview 不受责任池约束(只读试算,与人员池正确性无关)。
  208. ///
  209. /// <para>预演在独立的 <c>S8WatchRulePreviewService</c> 里,它整个不碰就绪门禁 ——
  210. /// 管理员本来就该「先预演看命中,再配人配部门,再启用」。若预演也要求先配人,
  211. /// 管理员将无法在配置前判断这条规则到底有没有用。</para>
  212. /// </summary>
  213. [Fact]
  214. public void Preview_IsNotGatedByHandlerPool()
  215. {
  216. var preview = CodeOnly("Service/S8/S8WatchRulePreviewService.cs");
  217. Assert.Contains("PreviewAsync", preview);
  218. Assert.DoesNotContain("EnsureReadyAsync", preview);
  219. Assert.DoesNotContain("_handlerPool", preview);
  220. Assert.DoesNotContain("IS8RuleHandlerPoolReader", preview);
  221. // 启用路径必须仍有门禁 —— 否则这条断言会在"门禁被整个删掉"时假通过。
  222. var ruleSvc = CodeOnly("Service/S8/S8WatchRuleService.cs");
  223. Assert.Contains("EnsureReadyAsync", ruleSvc);
  224. }
  225. // ══════════════════════════════════════════════════════════════════════════
  226. // 可见性
  227. // ══════════════════════════════════════════════════════════════════════════
  228. /// <summary>
  229. /// View 与 View All 分离:没有 <c>EXCEPTION_VIEW_ALL</c> 的账号只看得到
  230. /// 自己负责的规则产出的异常、人工提报、以及与自己直接相关的单子。
  231. ///
  232. /// <para>最后一支是必要的:单据可能在他认领之后被移出责任池,
  233. /// 少了它他会看不见自己手上正在处理的单子。</para>
  234. /// </summary>
  235. [Fact]
  236. public void Visibility_SeparatesViewFromViewAll()
  237. {
  238. var code = CodeOnly("Service/S8/S8ExceptionService.cs");
  239. Assert.Contains("S8ExceptionActionCode.ViewAll", code);
  240. Assert.Contains("myRuleCodes.Contains(e.SourceRuleCode)", code);
  241. Assert.Contains("SqlFunc.IsNullOrEmpty(e.SourceRuleCode)", code);
  242. Assert.Contains("e.AssigneeUserId == myUserId", code);
  243. Assert.Contains("e.VerifierUserId == myUserId", code);
  244. Assert.Contains("e.ReporterUserId == myUserId", code);
  245. }
  246. /// <summary>
  247. /// 无登录上下文(看板聚合 / 后台作业)与超管不做可见性收敛。
  248. /// 给它们加限制只会让统计数字凭空少掉,而且没人会想到去查这里。
  249. /// </summary>
  250. [Fact]
  251. public void Visibility_SkipsSuperAdminAndBackgroundCallers()
  252. {
  253. var code = CodeOnly("Service/S8/S8ExceptionService.cs");
  254. Assert.Contains("if (_userManager.SuperAdmin) return null;", code);
  255. Assert.Contains("if (userId <= 0 || tenantId <= 0) return null;", code);
  256. }
  257. /// <summary>
  258. /// <c>EXCEPTION_VIEW_ALL</c> 在 P1-B 建立时没有消费方,本批必须闭环 ——
  259. /// 否则它就是一个配了也不起作用的开关。
  260. /// </summary>
  261. [Fact]
  262. public void ViewAll_HasARealConsumer()
  263. {
  264. Assert.Contains(S8ExceptionActionCatalog.All, d => d.Code == S8ExceptionActionCode.ViewAll);
  265. var code = CodeOnly("Service/S8/S8ExceptionService.cs");
  266. Assert.Contains("allowed.Contains(S8ExceptionActionCode.ViewAll)", code);
  267. }
  268. // ══════════════════════════════════════════════════════════════════════════
  269. // 迁移
  270. // ══════════════════════════════════════════════════════════════════════════
  271. /// <summary>迁移建唯一索引 + 反查索引,并断言不存在跨租户池成员。</summary>
  272. [Fact]
  273. public void Migration_GuardsUniquenessAndTenantBoundary()
  274. {
  275. var sql = File.ReadAllText(Path.GetFullPath(Path.Combine(
  276. PluginRoot, "../../Admin.NET.Web.Entry/UpdateScripts/1.0.498.sql")));
  277. Assert.Contains("uk_s8_rule_handler", sql);
  278. Assert.Contains("idx_s8_rule_handler_user", sql);
  279. Assert.Contains("s8_498_BLOCKED_unique_index_missing", sql);
  280. Assert.Contains("s8_498_BLOCKED_cross_tenant_handler", sql);
  281. // 不写任何成员数据:成员是 per-tenant 人工配置,写死既不适配新租户也会覆盖管理员选择
  282. Assert.DoesNotContain("INSERT INTO `ado_s8_rule_handler_user`", sql);
  283. Assert.DoesNotContain("DELIMITER", sql);
  284. }
  285. }