S8RuleEnableReadinessTests.cs 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385
  1. using System.Reflection;
  2. using System.Text.Json;
  3. using Admin.NET.Plugin.AiDOP.Entity.S8;
  4. using Admin.NET.Plugin.AiDOP.Infrastructure.S8;
  5. using Admin.NET.Plugin.AiDOP.Service.S8;
  6. using Admin.NET.Plugin.AiDOP.Service.S8.Rules;
  7. using Admin.NET.Plugin.AiDOP.Service.S8.Rules.Definitions;
  8. using Xunit;
  9. namespace Admin.NET.Plugin.AiDOP.Tests.S8;
  10. /// <summary>
  11. /// S8-RULE-READINESS-1:启用就绪门禁。
  12. ///
  13. /// <para><b>要消灭的失败形态</b>:Rule 01 的数据集 <c>dwd_supplier_delivery</c> 没有部门列,
  14. /// 命中行带不出 occurrence / responsible,建单时部门只能来自运行参数。未配置时的实际表现是
  15. /// <c>tick_rule_done status=SUCCESS hits=28 created=0 failed=1</c> ——
  16. /// 规则显示「已启用 / 最近结果:成功」,异常一条都没有,页面上看不出任何原因。
  17. /// 每一层都报成功,正是最难被发现的那类缺陷。</para>
  18. ///
  19. /// <para><b>本文件守两件事</b>:① 三条真实执行入口(Enable / RunNow / Scheduler)
  20. /// 共用同一门禁,不得有旁路;② 该要求是<b>逐规则声明</b>的,不是 S8 全局规则 ——
  21. /// 未声明的规则必须完全不受影响。</para>
  22. /// </summary>
  23. public class S8RuleEnableReadinessTests
  24. {
  25. private const long TenantA = 838257186181189L;
  26. private const long TenantB = 838257212780613L;
  27. private const long DeptInA = 245L;
  28. private const long DeptInB = 252L;
  29. private static readonly string Rule01Code = S8PurchaseDeliveryRuleDefinitions.PurchaseDeliveryDateDelayCode;
  30. private static S8RuleDefinition Rule01() =>
  31. new S8RuleCatalog(new IS8RuleDefinitionSource[] { new S8PurchaseDeliveryRuleDefinitions() })
  32. .GetRequired(Rule01Code);
  33. /// <summary>不声明部门必需的规则(代表"数据集自带部门"的那一类)。</summary>
  34. private static S8RuleDefinition RuleWithoutDepartmentRequirement() => new()
  35. {
  36. RuleCode = "UT_RULE_NO_DEPT_REQUIRED",
  37. DisplayName = "单测规则",
  38. DatasetCode = "UT_DATASET",
  39. RuleType = "TIMEOUT",
  40. SourceObjectType = "ORDER",
  41. SceneCode = "S4",
  42. ExceptionTypeCode = "UT_TYPE",
  43. Timeout = new S8TimeoutSemantics { CompletedStates = new[] { "COMPLETED" } },
  44. Parameters = new S8RuleParameterPolicy() // RequiresDepartmentDefaultsForEnable 默认 false
  45. };
  46. private static AdoS8WatchRule Row(long tenantId, long? occ, long? resp) => new()
  47. {
  48. Id = 1,
  49. TenantId = tenantId,
  50. FactoryId = 0,
  51. RuleCode = Rule01Code,
  52. Enabled = false,
  53. PollIntervalSeconds = 300,
  54. TriggerCountRequired = 1,
  55. RecoverCountRequired = 2,
  56. Severity = "SERIOUS",
  57. ParamsJson = BuildParams(occ, resp)
  58. };
  59. private static string BuildParams(long? occ, long? resp)
  60. {
  61. var payload = new Dictionary<string, object> { ["graceMinutes"] = 0 };
  62. if (occ.HasValue) payload["defaultOccurrenceDeptId"] = occ.Value;
  63. if (resp.HasValue) payload["defaultResponsibleDeptId"] = resp.Value;
  64. return JsonSerializer.Serialize(payload);
  65. }
  66. /// <summary>
  67. /// 用假的部门校验器驱动门禁:真实实现要连库,而本文件要验的是<b>门禁的判定逻辑</b>。
  68. /// 「部门属于哪个租户」的真实判据由 <see cref="S8DepartmentScopeValidator"/> 独占,
  69. /// 其口径由 S8TenantOnlyExceptionScopeTests 的源码扫描守(tenant_id + IsActive,无 factory)。
  70. /// </summary>
  71. private sealed class FakeDeptValidator : IS8DepartmentScopeValidator
  72. {
  73. private readonly Dictionary<long, long> _deptTenant;
  74. public FakeDeptValidator(Dictionary<long, long> deptTenant) => _deptTenant = deptTenant;
  75. public Task<bool> ExistsInTenantAsync(long? deptId, long tenantId) =>
  76. Task.FromResult(deptId.HasValue && _deptTenant.TryGetValue(deptId.Value, out var t) && t == tenantId);
  77. }
  78. /// <summary>门禁实例:DeptInA 属租户 A,DeptInB 属租户 B。</summary>
  79. private static S8RuleReadinessGate Gate() =>
  80. new(new FakeDeptValidator(new Dictionary<long, long>
  81. {
  82. [DeptInA] = TenantA,
  83. [DeptInB] = TenantB
  84. }));
  85. private static Task<S8RuleReadinessCheck> Check(long tenantId, long? occ, long? resp, S8RuleDefinition? def = null)
  86. {
  87. var definition = def ?? Rule01();
  88. return Gate().CheckAsync(S8EffectiveRule.Resolve(Row(tenantId, occ, resp), definition), tenantId);
  89. }
  90. // ───────────────── T1–T6:就绪判定 ─────────────────
  91. /// <summary>T1:两个部门都为空 → 拒绝,且指名缺的是"发生部门"。</summary>
  92. [Fact]
  93. public async Task T1_BothDepartmentsMissing_IsRejected()
  94. {
  95. var r = await Check(TenantA, null, null);
  96. Assert.False(r.Ok);
  97. Assert.Equal(S8RuleReadinessReasonCode.RequiredParameterMissing, r.ReasonCode);
  98. Assert.Contains("默认发生部门", r.Message);
  99. }
  100. /// <summary>T2:只配了发生部门 → 仍拒绝,且指名缺的是"责任部门"(不能笼统报"参数缺失")。</summary>
  101. [Fact]
  102. public async Task T2_OnlyOccurrence_IsRejected()
  103. {
  104. var r = await Check(TenantA, DeptInA, null);
  105. Assert.False(r.Ok);
  106. Assert.Equal(S8RuleReadinessReasonCode.RequiredParameterMissing, r.ReasonCode);
  107. Assert.Contains("默认责任部门", r.Message);
  108. }
  109. /// <summary>T3:只配了责任部门 → 拒绝。</summary>
  110. [Fact]
  111. public async Task T3_OnlyResponsible_IsRejected()
  112. {
  113. var r = await Check(TenantA, null, DeptInA);
  114. Assert.False(r.Ok);
  115. Assert.Equal(S8RuleReadinessReasonCode.RequiredParameterMissing, r.ReasonCode);
  116. Assert.Contains("默认发生部门", r.Message);
  117. }
  118. /// <summary>T4:两者齐备且属本租户 → 放行。</summary>
  119. [Fact]
  120. public async Task T4_BothPresentAndInTenant_Passes()
  121. {
  122. var r = await Check(TenantA, DeptInA, DeptInA);
  123. Assert.True(r.Ok);
  124. Assert.Null(r.ReasonCode);
  125. }
  126. /// <summary>T5:发生部门属别的租户 → 拒绝,理由是"不属本租户"而非"缺失"。</summary>
  127. [Fact]
  128. public async Task T5_OccurrenceFromOtherTenant_IsRejected()
  129. {
  130. var r = await Check(TenantA, DeptInB, DeptInA);
  131. Assert.False(r.Ok);
  132. Assert.Equal(S8RuleReadinessReasonCode.DepartmentNotInTenant, r.ReasonCode);
  133. Assert.Contains("默认发生部门", r.Message);
  134. }
  135. /// <summary>T6:责任部门属别的租户 → 拒绝。</summary>
  136. [Fact]
  137. public async Task T6_ResponsibleFromOtherTenant_IsRejected()
  138. {
  139. var r = await Check(TenantA, DeptInA, DeptInB);
  140. Assert.False(r.Ok);
  141. Assert.Equal(S8RuleReadinessReasonCode.DepartmentNotInTenant, r.ReasonCode);
  142. Assert.Contains("默认责任部门", r.Message);
  143. }
  144. /// <summary>
  145. /// T7:工厂元数据不参与部门有效性。
  146. /// 同一条规则换任意 factory_id,判定结果必须逐字相同 —— 工厂在真库里横跨租户
  147. /// (factory_ref_id = 1000 同属 824585161322565 与 797403760988229),一旦参与判定就是跨租户放行。
  148. /// </summary>
  149. [Fact]
  150. public async Task T7_FactoryMetadata_DoesNotAffectDepartmentValidity()
  151. {
  152. var gate = Gate();
  153. var def = Rule01();
  154. var rowFactoryZero = Row(TenantA, DeptInA, DeptInA);
  155. rowFactoryZero.FactoryId = 0;
  156. var rowFactoryOther = Row(TenantA, DeptInA, DeptInA);
  157. rowFactoryOther.FactoryId = 999_999_999L;
  158. var a = await gate.CheckAsync(S8EffectiveRule.Resolve(rowFactoryZero, def), TenantA);
  159. var b = await gate.CheckAsync(S8EffectiveRule.Resolve(rowFactoryOther, def), TenantA);
  160. Assert.True(a.Ok);
  161. Assert.True(b.Ok);
  162. // 门禁签名里不得出现工厂形参。
  163. foreach (var m in typeof(S8RuleReadinessGate).GetMethods(BindingFlags.Instance | BindingFlags.Public)
  164. .Where(x => x.Name is "CheckAsync" or "EnsureReadyAsync"))
  165. {
  166. Assert.DoesNotContain(m.GetParameters(), p =>
  167. p.Name!.Contains("factory", StringComparison.OrdinalIgnoreCase));
  168. }
  169. }
  170. // ───────────────── T8–T9:Preview 与 RunNow 的分野 ─────────────────
  171. /// <summary>
  172. /// T8:Preview 不受门禁约束。
  173. ///
  174. /// <para>预演只做只读试算、不建任何异常,部门缺失不影响它的正确性;
  175. /// 反过来说,管理员本来就该「先预演看命中,再配部门,再启用」。
  176. /// 若把门禁接到 Preview 上,等于逼人在看不到命中的情况下先猜配置。</para>
  177. /// </summary>
  178. [Fact]
  179. public void T8_PreviewPath_DoesNotConsultReadinessGate()
  180. {
  181. var previewSource = CodeOnly("Service/S8/S8WatchRulePreviewService.cs");
  182. Assert.DoesNotContain("S8RuleReadinessGate", previewSource);
  183. Assert.DoesNotContain("EnsureReadyAsync", previewSource);
  184. }
  185. /// <summary>
  186. /// T9:RunNow 会真实建单,必须复核与 Enable 同一门禁。
  187. /// 只在 Enable 处挡是不够的:规则可能启用后部门被停用 / 删除 / 改到别的租户。
  188. /// </summary>
  189. [Fact]
  190. public void T9_RunNowPath_ConsultsReadinessGate()
  191. {
  192. var code = CodeOnly("Service/S8/S8WatchRuleService.cs");
  193. var runNowBody = Slice(code, "public async Task<object> RunNowAsync", "public async Task<object> PauseAsync");
  194. Assert.Contains("_readinessGate.EnsureReadyAsync", runNowBody);
  195. }
  196. // ───────────────── T10–T11:供给与作用范围 ─────────────────
  197. /// <summary>T10:供给出来的 Rule01 不猜部门、不自动启用。</summary>
  198. [Fact]
  199. public void T10_Provisioning_LeavesDepartmentsUnsetAndDisabled()
  200. {
  201. var code = CodeOnly("Service/S8/S8RuleProvisioningService.cs");
  202. Assert.Contains("Enabled = false", code);
  203. // 供给不得写入任何默认部门 —— "猜一个部门"比"拒绝启用"糟得多:
  204. // 异常会带着错误的责任部门流转,且没人会发现。
  205. Assert.DoesNotContain("DefaultOccurrenceDeptId", code);
  206. Assert.DoesNotContain("DefaultResponsibleDeptId", code);
  207. Assert.DoesNotContain("defaultOccurrenceDeptId", code);
  208. }
  209. /// <summary>
  210. /// T11:未声明该要求的规则完全不受影响。
  211. /// 这条防的是"顺手把要求提成全局"——数据集自带部门的规则会被一起误伤。
  212. /// </summary>
  213. [Fact]
  214. public async Task T11_RuleWithoutRequirement_IsNotAffected()
  215. {
  216. var def = RuleWithoutDepartmentRequirement();
  217. Assert.False(def.Parameters!.RequiresDepartmentDefaultsForEnable);
  218. var r = await Check(TenantA, null, null, def);
  219. Assert.True(r.Ok);
  220. Assert.Null(r.ReasonCode);
  221. }
  222. // ───────────────── T12–T13:Scheduler 与三路径同源 ─────────────────
  223. /// <summary>
  224. /// T12:已启用规则的部门事后失效 → Scheduler 在 evaluator 之前 fail-fast。
  225. ///
  226. /// <para>判定层面:部门被改到别的租户后,门禁必须返回 not-ok(即 Scheduler 会拿到 false)。</para>
  227. /// <para>接线层面:该检查必须位于 <c>ProcessSingleRuleAsync</c> 调用<b>之前</b>,
  228. /// 且失败时 <c>return</c> 而不是继续 —— 否则就变成"先建单失败再记录",
  229. /// 正是本轮要消灭的 <c>create_failed</c>。同时不得在此自动停用规则。</para>
  230. /// </summary>
  231. [Fact]
  232. public async Task T12_SchedulerFailsFast_WhenDepartmentBecomesInvalid()
  233. {
  234. // ① 判定:启用时合法的配置,在部门被移出本租户后必须变为不就绪。
  235. var stillValid = await Check(TenantA, DeptInA, DeptInA);
  236. Assert.True(stillValid.Ok);
  237. var nowInvalid = await Check(TenantA, DeptInB, DeptInB); // 部门已属别的租户
  238. Assert.False(nowInvalid.Ok);
  239. Assert.Equal(S8RuleReadinessReasonCode.DepartmentNotInTenant, nowInvalid.ReasonCode);
  240. // ② 接线:readiness 检查必须早于 evaluator 分派与 ProcessSingleRuleAsync。
  241. var code = CodeOnly("Service/S8/S8WatchSchedulerService.cs");
  242. var body = Slice(code, "public async Task<S8RuleRunResult> RunSingleRuleAsync", "private async Task<List<S8WatchCreationResult>> ProcessSingleRuleAsync");
  243. var gateAt = body.IndexOf("_readinessGate.CheckAsync", StringComparison.Ordinal);
  244. var evaluatorAt = body.IndexOf("IS8RuleEvaluator? evaluator", StringComparison.Ordinal);
  245. var processAt = body.IndexOf("ProcessSingleRuleAsync(", StringComparison.Ordinal);
  246. Assert.True(gateAt >= 0, "Scheduler 未接入 readiness 门禁");
  247. Assert.True(evaluatorAt > gateAt, "readiness 检查必须早于 evaluator 分派");
  248. Assert.True(processAt > gateAt, "readiness 检查必须早于 ProcessSingleRuleAsync");
  249. // 失败即 return,不落到下游。
  250. var afterGate = body[gateAt..];
  251. var returnAt = afterGate.IndexOf("return new S8RuleRunResult", StringComparison.Ordinal);
  252. Assert.True(returnAt >= 0 && returnAt < afterGate.IndexOf("ProcessSingleRuleAsync(", StringComparison.Ordinal),
  253. "readiness 失败必须直接返回失败结果,不得继续执行");
  254. // 不自动停用:门禁失败路径里不得出现 Enabled = false。
  255. var failureBranch = afterGate[..afterGate.IndexOf("ProcessSingleRuleAsync(", StringComparison.Ordinal)];
  256. Assert.DoesNotContain("Enabled = false", failureBranch);
  257. }
  258. /// <summary>
  259. /// T13:Enable / RunNow / Scheduler 三条入口共用同一 readiness policy。
  260. ///
  261. /// <para>防的是未来分叉:任何一条自己写一套"要不要部门"的判断,就会出现
  262. /// 「启用被挡但 RunNow 能跑」或「启用通过但调度器拒绝」这类互相矛盾的结论。
  263. /// 因此三处都必须走 <see cref="S8RuleReadinessGate"/>,且都不得自行解析 params_json。</para>
  264. /// </summary>
  265. [Fact]
  266. public void T13_ThreeExecutionEntryPoints_ShareOneReadinessPolicy()
  267. {
  268. var ruleService = CodeOnly("Service/S8/S8WatchRuleService.cs");
  269. var scheduler = CodeOnly("Service/S8/S8WatchSchedulerService.cs");
  270. var enableBody = Slice(ruleService, "public async Task<AdoS8WatchRule> EnableAsync", "public async Task<AdoS8WatchRule> DisableAsync");
  271. var runNowBody = Slice(ruleService, "public async Task<object> RunNowAsync", "public async Task<object> PauseAsync");
  272. var schedulerBody = Slice(scheduler, "public async Task<S8RuleRunResult> RunSingleRuleAsync", "private async Task<List<S8WatchCreationResult>> ProcessSingleRuleAsync");
  273. foreach (var (name, body) in new[] { ("EnableAsync", enableBody), ("RunNowAsync", runNowBody), ("RunSingleRuleAsync", schedulerBody) })
  274. {
  275. Assert.True(body.Contains("_readinessGate.", StringComparison.Ordinal), $"{name} 未接入 S8RuleReadinessGate");
  276. // 三处都必须把已解析的生效形态交给门禁,而不是自己再解一次 params_json。
  277. // 门禁看到的参数与 evaluator 用的参数必须同源,否则是另一种静默背离。
  278. Assert.True(body.Contains("S8EffectiveRule.Resolve", StringComparison.Ordinal), $"{name} 未传入 S8EffectiveRule");
  279. Assert.DoesNotContain("JsonDocument.Parse", body);
  280. Assert.DoesNotContain("defaultOccurrenceDeptId", body);
  281. }
  282. // 门禁自身也不得重新解析 params_json。
  283. var gateCode = CodeOnly("Service/S8/Rules/S8RuleReadinessGate.cs");
  284. Assert.DoesNotContain("JsonDocument", gateCode);
  285. Assert.DoesNotContain("ParamsJson", gateCode);
  286. }
  287. /// <summary>部门合法性只能有一份实现:ManualReport 侧必须委派给共享校验器。</summary>
  288. [Fact]
  289. public void DepartmentValidity_HasSingleImplementation()
  290. {
  291. var manualReport = CodeOnly("Service/S8/S8ManualReportService.cs");
  292. Assert.Contains("_deptValidator.ExistsInTenantAsync", manualReport);
  293. // 被抽走的那份实现(按主键校验部门归属)必须消失,否则两份判据迟早分叉。
  294. // 只钉这一种形状:同文件里按 Department 编码 / SysUserId 查询的语句是**别的用途**,
  295. // 用宽泛断言会把它们一起误伤。
  296. Assert.DoesNotContain("x.Id == deptId.Value && x.TenantId == tenantId", manualReport);
  297. Assert.DoesNotContain("x.Id == deptId", manualReport);
  298. }
  299. // ───────────────── helpers ─────────────────
  300. private static string Slice(string code, string from, string to)
  301. {
  302. var a = code.IndexOf(from, StringComparison.Ordinal);
  303. Assert.True(a >= 0, $"未找到锚点:{from}");
  304. var b = code.IndexOf(to, a, StringComparison.Ordinal);
  305. return b > a ? code[a..b] : code[a..];
  306. }
  307. private static string CodeOnly(string relative)
  308. {
  309. var dir = new DirectoryInfo(AppContext.BaseDirectory);
  310. while (dir != null && !Directory.Exists(Path.Combine(dir.FullName, "Admin.NET.Plugin.AiDOP")))
  311. dir = dir.Parent;
  312. Assert.NotNull(dir);
  313. var full = Path.Combine(dir!.FullName, "Admin.NET.Plugin.AiDOP",
  314. relative.Replace('/', Path.DirectorySeparatorChar));
  315. Assert.True(File.Exists(full), $"源码文件不存在,路径需同步更新:{full}");
  316. return string.Join('\n', File.ReadAllLines(full)
  317. .Where(l =>
  318. {
  319. var t = l.TrimStart();
  320. return !t.StartsWith("///", StringComparison.Ordinal)
  321. && !t.StartsWith("//", StringComparison.Ordinal);
  322. }));
  323. }
  324. }